Remove the no-data case, the tables are more informative

smarr · Jul 18, 2023 · 25c70ce · 25c70ce
1 parent 1d65022
commit 25c70ce
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 14 deletions.
diff --git a/src/backend/compare/html/index.html b/src/backend/compare/html/index.html
@@ -61,14 +61,6 @@ <h4 class="alert-heading">Revisions Not Found</h4>
 </div>
 {% } %}
 
-{% if (it.noData) { %}
-<div class="compare">
-  <h3>Issue with Unexpected Data</h3>
-  <p>The data provided for baseline and change does not seem to have a common benchmarks/executors.</p>
-  <p>This is known to happen for instance, when benchmarks or parameters are changed, or executors renamed.</p>
-</div>
-{% } %}
-
 {% if (it.revisionFound) { %}
 <div id="version-details" class="compare">
   <h2>Version Details</h2>

diff --git a/src/backend/compare/prep-data.ts b/src/backend/compare/prep-data.ts
@@ -1089,7 +1089,6 @@ export async function prepareCompareView(
     navigation,
     hasExeComparison: navigation.navExeComparison.suites.length > 0,
 
-    noData: false, // TODO: need to derive this from one of the stats details
     notInBoth: allStats.acrossVersions.missing.length > 0,
 
     stats: { ...allStats, environments },

diff --git a/src/shared/view-types.ts b/src/shared/view-types.ts
@@ -210,7 +210,6 @@ export interface CompareViewWithoutData extends CompareViewBasics {
 export interface CompareViewWithData extends CompareViewBasics {
   revisionFound: true;
 
-  noData: boolean;
   notInBoth: boolean;
 
   base: RevisionData;

diff --git a/tests/data/expected-results/stats-data-prep/compare-view-jssom.html b/tests/data/expected-results/stats-data-prep/compare-view-jssom.html
@@ -77,8 +77,6 @@ <h3>Comparing <a href="repo-url/compare/4dff7e...bc1105">4dff7e with bc1105</a><
 
 
 
-
-
 <div id="version-details" class="compare">
   <h2>Version Details</h2>
   <dl class="row">

diff --git a/tests/data/expected-results/stats-data-prep/compare-view-tsom.html b/tests/data/expected-results/stats-data-prep/compare-view-tsom.html
@@ -77,8 +77,6 @@ <h3>Comparing <a href="repo-url/compare/5820ec...5fa4bd">5820ec with 5fa4bd</a><
 
 
 
-
-
 <div id="version-details" class="compare">
   <h2>Version Details</h2>
   <dl class="row">