-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Measurement table to store iteration values in an array instead of in rows #100
Commits on Mar 20, 2024
-
Use value array per invocation in Measurement table instead of row pe…
…r iteration - added measurement table migration script Co-authored-by: Humphrey Burchell <[email protected]> Co-authored-by: Stefan Marr <[email protected]> Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 09a2dc9 - Browse repository at this point
Copy the full SHA 09a2dc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a12938 - Browse repository at this point
Copy the full SHA 0a12938View commit details
Commits on Mar 21, 2024
-
Adapt more code to the assumption that iterations are encoded as part…
… of Measurement.values - add a little more typing - rename Measurement.value to values - refactor data preparation to simply create value batches for insertion - remove old test not needed anymore - updated small-payload.json to new API format - only consider non-null values for timeline computation Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3f2c723 - Browse repository at this point
Copy the full SHA 3f2c723View commit details -
Don’t need to explictly record metadata and runs
Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f7d6f4f - Browse repository at this point
Copy the full SHA f7d6f4fView commit details -
Added support to convert data from old API to new format
This is not a feature to be exposed, this is merely intended for testing, and converting the large-payload file. It also helps to define more explicitly what the complete API definition is, because of missing values and criteria without data. Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7e2640d - Browse repository at this point
Copy the full SHA 7e2640dView commit details -
Use loadLargePayload() in other tests and benchmarks
Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 36ae6ee - Browse repository at this point
Copy the full SHA 36ae6eeView commit details -
Reimplement pref-tracking for self-tracking
Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a537700 - Browse repository at this point
Copy the full SHA a537700View commit details -
Added completeRequestAndHandlePromise which is hiding the promise
This is hopefully easier to use, and reports errors consistently. Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a5c2206 - Browse repository at this point
Copy the full SHA a5c2206View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83f606d - Browse repository at this point
Copy the full SHA 83f606dView commit details -
Fix up test with large payload
Some of these numbers are still odd, but oh well… Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a28f465 - Browse repository at this point
Copy the full SHA a28f465View commit details -
Fix resolveCriteria, need to use the id in the client’s data, not the…
… database id Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bff392b - Browse repository at this point
Copy the full SHA bff392bView commit details -
Move loadLargePayload() to separate file to avoid issues with jest in…
… benchmarks It complains as follows, which we can just avoid: file:///project/dist/tests/helpers.js:1 import { expect } from '@jest/globals'; ^^^^^^ SyntaxError: Named export 'expect' not found. The requested module '@jest/globals' is a CommonJS module, which may not support all module.exports as named exports. CommonJS modules can always be imported via the default export, for example using: Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e80ad3f - Browse repository at this point
Copy the full SHA e80ad3fView commit details -
Fix benchmark sizing by using old data format
- load old format, do sizing as before, and then convert Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1e3cf20 - Browse repository at this point
Copy the full SHA 1e3cf20View commit details -
Added basic tests for the standard responses
This is mostly to have them covered… Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 827c172 - Browse repository at this point
Copy the full SHA 827c172View commit details -
Move TimelineWorker bit out of BatchingTimelineUpdater and test it.
Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ee03b9c - Browse repository at this point
Copy the full SHA ee03b9cView commit details -
Add basic tests for BatchingTimelineUpdater and do a little bit of an…
… optimization - rename methods for benchmarking (also used for convenience in test) - avoid creating empty jobs Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9a2d81b - Browse repository at this point
Copy the full SHA 9a2d81bView commit details -
Send timeline compute jobs as batches
Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a4fccca - Browse repository at this point
Copy the full SHA a4fcccaView commit details -
Add more tests for addValues()
Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2871e02 - Browse repository at this point
Copy the full SHA 2871e02View commit details -
Quiescence needs to check for new pending jobs
Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0acea95 - Browse repository at this point
Copy the full SHA 0acea95View commit details -
Refactor BatchingTimelineUpdater to make it easier to test
Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9fdcaac - Browse repository at this point
Copy the full SHA 9fdcaacView commit details -
Added tests for createValueBatchForInsertion()
Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6092879 - Browse repository at this point
Copy the full SHA 6092879View commit details -
Fix bug in createValueBatchForInsertion() which leads to wrong criter…
…ion ids being used. We didn’t increment the criterionId when no measurements were available, which lead to a wrong mapping of the ids used in the input data to ids used in the database. Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8655fa3 - Browse repository at this point
Copy the full SHA 8655fa3View commit details -
Fix expectedTimelineRowCount, the data in the table looks plausible
Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for adb31c1 - Browse repository at this point
Copy the full SHA adb31c1View commit details -
Fix Measurements type for data retrived from DB
- account for new data format with ValuesPossiblyMissing Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f6530c3 - Browse repository at this point
Copy the full SHA f6530c3View commit details -
Use new helper functions to load data and convert it to new format
The functions are in the next commit. Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f18b768 - Browse repository at this point
Copy the full SHA f18b768View commit details -
Finish the migration to the new MeasurementData encoding
Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 100a04b - Browse repository at this point
Copy the full SHA 100a04bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b57df52 - Browse repository at this point
Copy the full SHA b57df52View commit details -
Unnest arrays in data export to be easier to work with and closer to …
…the ReBench data file format - merge redundant type declaration - filter out NULL value in the database Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 107ded2 - Browse repository at this point
Copy the full SHA 107ded2View commit details -
Check for use of API version 2, if not report an error
Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5edef30 - Browse repository at this point
Copy the full SHA 5edef30View commit details -
Use es2022 as compilation target to enable use of Object.hasOwn()
Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b48b9d9 - Browse repository at this point
Copy the full SHA b48b9d9View commit details
Commits on Mar 23, 2024
-
Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1777292 - Browse repository at this point
Copy the full SHA 1777292View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94dfe6c - Browse repository at this point
Copy the full SHA 94dfe6cView commit details -
The corresponding PR for the new API support is now merged. And since I didn’t update the docker file, the merge there is actually needed to see whether the benchmarking of ReBenchDB with ReBench itself works. Signed-off-by: Stefan Marr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e8d018f - Browse repository at this point
Copy the full SHA e8d018fView commit details