Implement per-benchmark over-time plots in comparison view #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Marr <[email protected]>
…source Fix naming of pretest script, was prep-resource before, which doesn’t make sense anymore. Signed-off-by: Stefan Marr <[email protected]>
- also adjust button size to be slightly smaller Signed-off-by: Stefan Marr <[email protected]>
This encodes the parameters of the benchmark on the button, and uses project name and baseline and change commit ids from the meta data of the page. To distinguish the baseline and change branches, we request them first based on the commit ids. The response to the UI is already prepared for display. The plots are generated with uPlot, a lightweight canvas-based library. This seems more scalable than plot.ly. To make TypeScript happy about uPlot, added path mappings, which makes the code work in the browser, too. Signed-off-by: Stefan Marr <[email protected]>
…the command line - align whitespace Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
…oying the system Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
- in the database, also determine whether a datapoint is the current one - send the time stamp details to the client. this avoids having to send a lot of nulls in arrays - on client, add data series that only contain the point to highlight, and display that one larger and filled with the light color Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
- make the legend a proper table, that doesn’t jiggle as much around Signed-off-by: Stefan Marr <[email protected]>
In the comparison view we however still want the current data point then being indicated as changed data point. Strictly speaking, we’re missing the current data point for the baseline, though, well, that’s something for another day… Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
This was referenced Jul 31, 2022
Signed-off-by: Stefan Marr <[email protected]>
…t is used for Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
|
Some examples: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements (part of) #104.
The comparison report now has an extra button to request the timeline/over-time plot for the benchmark.
It will show the data from the baseline and change branch, and highlight the current commit for both branches on the plot.
It will also indicate the 95th bootstrap confidence interval.
The implementation handles the cases where both commits are on the same branch, too.
Here, only the change commit is currently highlighted.
For the plots, I am using the uPlot library, instead of plot.ly.
It's more light-weight, which is likely of benefit for the already large report pages.
Other Changes
tslogas library for more readable logs (Make log files more readable #72).assert()method that gives a stack trace instead of just printingAssertion Failedinto the lognumBootstrapSamples, it was very cryptic and ambiguous before (numReplicates)