chore(ms-config): replace fake json comments with C-style comments #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that the MS Anonymizer tool actually does support json
comments, using C-style /* */ and // syntax.
I really thought I had tested that at some point.
So this commit just converts all the fake {"comment": "my text"} lines
into real comments. And adds a comment for every field skipped (i.e.
adds a comment for every field you wouldn't otherwise see because we
use an allow-list)
No functionality changes. (Except de-id might be faster now that it has
less fake rules to attempt to apply.)
dogversioning
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that the MS Anonymizer tool actually does support json comments, using C-style /* */ and // syntax.
I really thought I had tested that at some point.
So this commit just converts all the fake {"comment": "my text"} lines into real comments. And adds a comment for every field skipped (i.e. adds a comment for every field you wouldn't otherwise see because we use an allow-list)
No functionality changes. (Except de-id might be faster now that it has less fake rules to attempt to apply.)
Checklist
docs/) needs to be updated