Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHIP-2006 Consolidate All FinalityDepth Settings to default TOML files #1151

Merged
merged 30 commits into from
Nov 6, 2024
Merged

SHIP-2006 Consolidate All FinalityDepth Settings to default TOML files #1151

merged 30 commits into from
Nov 6, 2024

Conversation

adityavadhavkar1215
Copy link
Contributor

@adityavadhavkar1215 adityavadhavkar1215 commented Jul 8, 2024 •
edited
Loading

Motivation

Ticket

Solution

Updated the values of FinalityDepth setting to make it the same as the values set in infra-k8s repo.

@adityavadhavkar1215 adityavadhavkar1215 marked this pull request as ready for review July 8, 2024 01:15
@adityavadhavkar1215 adityavadhavkar1215 requested a review from a team as a code owner July 8, 2024 01:15
simsonraj
simsonraj reviewed Jul 9, 2024
View reviewed changes
docs/CONFIG.md Outdated Show resolved Hide resolved
simsonraj
simsonraj reviewed Jul 9, 2024
View reviewed changes
docs/CONFIG.md Outdated Show resolved Hide resolved
simsonraj
simsonraj requested changes Jul 9, 2024
View reviewed changes
docs/CONFIG.md Outdated Show resolved Hide resolved
docs/CONFIG.md Outdated Show resolved Hide resolved
@Madalosso
Copy link
Contributor

The latest commit added the main net values set by CCIP Node Setup Guide

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

stackman27
stackman27 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@stackman27 stackman27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

please add additional comments as discussed before merging

@Madalosso
Copy link
Contributor

Blocked by #1514 (CI failure)

@Madalosso Madalosso merged commit 96ed6ec into ccip-develop Nov 6, 2024
136 of 138 checks passed
@Madalosso Madalosso deleted the SHIP-1754-Consolidate-all-FinalityDepth-settings branch November 6, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simsonraj simsonraj simsonraj approved these changes

@friedemannf friedemannf friedemannf approved these changes

@dhaidashenko dhaidashenko dhaidashenko approved these changes

@stackman27 stackman27 stackman27 approved these changes

@Madalosso Madalosso Madalosso approved these changes

@matYang matYang matYang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@adityavadhavkar1215 @Madalosso @matYang @simsonraj @stackman27 @dhaidashenko @friedemannf