Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create dummy RMN contract for testing w/o RMN verification #1418

Closed
wants to merge 1 commit into from
Closed

Create dummy RMN contract for testing w/o RMN verification #1418

wants to merge 1 commit into from

Conversation

RyanRHall
Copy link
Contributor

Motivation

Unblock E2E testing

Solution

Create a dummy RMN contract that doesn't verify RMN sigs or curse

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

LCOV of commit 931ac32 during Solidity Foundry #8043

Summary coverage rate:
  lines......: 97.5% (2154 of 2209 lines)
  functions..: 94.4% (408 of 432 functions)
  branches...: 93.4% (512 of 548 branches)

Files changed coverage rate: n/a

⛔ The code coverage is too low: 97.51. Expected at least 97.6.

RayXpub
RayXpub reviewed Sep 6, 2024
View reviewed changes
contracts/src/v0.8/ccip/rmn/DummyRMN.sol
import {Internal} from "../libraries/Internal.sol";

/// @dev XXX DO NOT USE THIS CONTRACT, FOR TESTING ONLY XXX
contract DummyRMN is IRMNV2 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rename to MockRMNRemote?

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@RensR
Copy link
Collaborator

RensR commented Sep 11, 2024

Let's use the real RMN contract with dummy config instead of a new contract?

@RyanRHall
Copy link
Contributor Author

Closing, seems this was not necessary

@RyanRHall RyanRHall closed this Oct 2, 2024
@RyanRHall RyanRHall deleted the dummy-rmn-contract branch October 2, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RayXpub RayXpub RayXpub left review comments

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanRHall @RensR @RayXpub