CCIP-3420: Fix IsRequestTriggeredWithinTimeframe #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnieeG
requested changes
Sep 16, 2024
| if err != nil { | ||
| return nil, fmt.Errorf("error while on ramp contract. Error: %v", err) | ||
| } | ||
| iterator, err := onRampContract.FilterCCIPSendRequested(&bind.FilterOpts{ |
There was a problem hiding this comment.
no need for additional filtering you can just set the start block in existing watchEvents
There was a problem hiding this comment.
I tried that approach, but it appears that the filter is effective for retrieving historical events, while the watcher captures live events. As discussed, I have added a new function: it uses the filter approach for the first message to handle historical events and the watcher approach for subsequent messages to handle live events.
gheorghestrimtu
approved these changes
Sep 18, 2024
AnieeG
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The prior approach to find if there is traffic in a lane was not detecting the transactions properly. It could be due to the
CCIPSendRequestedWatchercaptures the event after it is initiated not any transaction before that.Solution
The revised approach is to use the FilterCCIPSendRequested by a past derived block number and see if there is any traffic. The block number is derived by this formula:
filterFromBlock = latestBlockNumber - (SkipRequestIfAnotherRequestTriggeredWithin/avgBlockTime)By this approach, we will be able to find traffic better.
https://smartcontract-it.atlassian.net/browse/CCIP-3420