Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RMN_V1_6_ANY2EVM_REPORT to RMNRemote and make public #1447

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Add RMN_V1_6_ANY2EVM_REPORT to RMNRemote and make public #1447

merged 3 commits into from
Sep 18, 2024

Conversation

RyanRHall
Copy link
Collaborator

Motivation

#1431 (comment)

Solution

Expose the constant as public

@RyanRHall RyanRHall requested a review from a team as a code owner September 18, 2024 15:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 18, 2024 •
edited
Loading

LCOV of commit 5015b4d during Solidity Foundry #8254

Summary coverage rate:
  lines......: 97.7% (2280 of 2334 lines)
  functions..: 94.6% (421 of 445 functions)
  branches...: 93.6% (542 of 579 branches)

Files changed coverage rate: n/a

@RyanRHall RyanRHall enabled auto-merge (squash) September 18, 2024 15:57
jhweintraub
jhweintraub reviewed Sep 18, 2024
View reviewed changes
contracts/src/v0.8/ccip/rmn/RMNRemote.sol Outdated
@@ -174,6 +174,10 @@ contract RMNRemote is OwnerIsCreator, ITypeAndVersion, IRMNV2 {
return i_localChainSelector;
}

function getReportDigestHeader() external pure returns (bytes32) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

natspec?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 oops!

jhweintraub
jhweintraub reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@jhweintraub jhweintraub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment requested otherwise looks good.

@RyanRHall RyanRHall merged commit 0a2d960 into ccip-develop Sep 18, 2024
120 checks passed
@RyanRHall RyanRHall deleted the rmn-remote-constant-expose branch September 18, 2024 16:28
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makramkd makramkd makramkd approved these changes

@jhweintraub jhweintraub jhweintraub approved these changes

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas is a code owner

@RayXpub RayXpub Awaiting requested review from RayXpub RayXpub is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanRHall @makramkd @jhweintraub