Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge FeePaid event into CCIPMessageSent #1456

Merged
merged 3 commits into from
Sep 23, 2024
Merged

merge FeePaid event into CCIPMessageSent #1456

merged 3 commits into from
Sep 23, 2024

Conversation

RyanRHall
Copy link
Contributor

@RyanRHall RyanRHall commented Sep 20, 2024 •
edited
Loading

Motivation

Not sure actually why this was needed. Request was made here.

This is the 2nd version, that alters the MessageSent struct. First version here.

Solution

Merge fields from FeePaid event into CCIPMessageSent event

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

LCOV of commit dfd936f during Solidity Foundry #8297

Summary coverage rate:
  lines......: 97.7% (2281 of 2335 lines)
  functions..: 94.6% (421 of 445 functions)
  branches...: 93.6% (542 of 579 branches)

Files changed coverage rate: n/a

@RyanRHall RyanRHall mentioned this pull request Sep 20, 2024
Closed
@RyanRHall RyanRHall enabled auto-merge (squash) September 20, 2024 16:33
@RyanRHall RyanRHall enabled auto-merge (squash) September 20, 2024 18:03
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@RyanRHall RyanRHall merged commit c8753d1 into ccip-develop Sep 23, 2024
127 checks passed
@RyanRHall RyanRHall deleted the CCIP-3446-merge-fee-paid-event-into-ccip-message-sent-2 branch September 23, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RayXpub RayXpub RayXpub approved these changes

@jhweintraub jhweintraub jhweintraub approved these changes

@connorwstein connorwstein connorwstein approved these changes

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RyanRHall @connorwstein @jhweintraub @RayXpub