Add DiscoveryProcessor to commit plugin. #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
force-pushed
the
will/onramp-observations-pt5
branch
3 times, most recently
from
fe0af79
to
4ee5e32
Compare
makramkd
approved these changes
Sep 19, 2024
winder
force-pushed
the
will/onramp-observations-pt5
branch
from
4ee5e32
to
acea493
Compare
Test Coverage
|
0xnogo
reviewed
Sep 20, 2024
| if err != nil { | ||
| p.lggr.Errorw("failed to discover contracts", "err", err) | ||
| } | ||
| if !p.contractsInitialized { |
There was a problem hiding this comment.
If contract addresses change, is there a risk of having stale addresses?
There was a problem hiding this comment.
Contract addresses won't change but we could have new chains added while the plugin is running.
However, the discovery processor continuously discovers new addresses at the moment, so these new chains get picked up. There's also a test for this in chainlink.
There was a problem hiding this comment.
A new address would be a problem because we don't unbind the old one and currently ensure that there is only one bound address. This is something we could support pretty easily if we need to in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add contract discovery to the commit plugin.