-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BCI-887] Solana HeadTracker Integration #521
Draft
yongkangc
wants to merge
47
commits into
develop
Choose a base branch
from
BCI-887-Solana-HeadTracker
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongkangc
changed the title
Added HeadTracker in Solana
[BCI-887] Added HeadTracker in Solana
Jun 9, 2023
} | ||
|
||
func (h *Head) earliestInChain() *Head { | ||
for h.Parent != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add this:
if h == nil {
return nil
}
|
||
func (h *Head) HashAtHeight(slotNum int64) Hash { | ||
for { | ||
if h.Slot == slotNum { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be able to optimize logic here.
For example, if slotNum is higher than current slot, then return Hash{}. This way, you return quicker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to integrate the chain specific headtracker on the EVM generalised platform based on the Epic ticket on chain specific headtracker.
This is a POC on how likely the generalised headtracker could be implemented in a chain specific context, will remain as a draft PR for now given all changes that are likely to happen with the Headtracker.
Changes:
pkg/common
is added to replicate imports onchainlink-relay
Note:
References: