Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChainComponents EVM Interface Tests #13735

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

silaslenihan
Copy link
Contributor

@silaslenihan silaslenihan commented Jul 1, 2024

Description: Changes the ChainReader EVM Interface tests to use the ChainWriter instead of a helper and updates the simulated backend ChainReader tests to implement a TXM + ChainWriter

Corresponding ticket:

Requires Dependencies

Resolves Dependencies

@silaslenihan silaslenihan force-pushed the cw-evm-interface-tests branch 6 times, most recently from 35bc9a2 to 485439d Compare July 15, 2024 22:32
@silaslenihan silaslenihan changed the base branch from develop to BCI-3486-implement-finality-check-for-the-get-transaction-status-method July 15, 2024 22:32
@ilija42 ilija42 changed the base branch from ocr2vrf-flakey-test to develop September 5, 2024 14:24
@ilija42 ilija42 dismissed patrick-dowell’s stale review September 5, 2024 14:24

The base branch was changed.

@ilija42
Copy link
Contributor

ilija42 commented Sep 5, 2024

whats up with the commit history?

I believe Amit's commits are included in this PR because I was dependent on the Finazlier changes he was working on. While those were still in progress I based this branch on his branch. I'm not sure why they are still there though because I rebased on top of develop

HIs commits got squashed so when you rebase it doesn't recognize them

Copy link
Contributor

@ilija42 ilija42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are effectively duplicating commit history although it will squash, but your squashed commit msg won't reflect the actual changes

@silaslenihan silaslenihan force-pushed the cw-evm-interface-tests branch 4 times, most recently from b9c4b85 to 46b89ea Compare September 5, 2024 16:58
EasterTheBunny
EasterTheBunny previously approved these changes Sep 5, 2024
@ilija42 ilija42 added this pull request to the merge queue Sep 5, 2024
Merged via the queue into develop with commit 920413c Sep 5, 2024
134 checks passed
@ilija42 ilija42 deleted the cw-evm-interface-tests branch September 5, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants