-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the old log buffer #13821
Merged
Merged
Remove the old log buffer #13821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferglor
force-pushed
the
feature/AUTO-9355-3
branch
from
July 16, 2024 15:26
1b4c91e
to
64fe028
Compare
krehermann
previously approved these changes
Jul 17, 2024
infiloop2
reviewed
Jul 19, 2024
@@ -538,13 +503,7 @@ func (p *logEventProvider) readLogs(ctx context.Context, latest int64, filters [ | |||
|
|||
func (p *logEventProvider) syncBufferFilters() error { | |||
p.lock.RLock() | |||
buffVersion := p.opts.BufferVersion | |||
p.lock.RUnlock() | |||
defer p.lock.RUnlock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can probably remove the Lock/unlock completely here since we dont need to read buffer version
ferglor
force-pushed
the
feature/AUTO-9355-3
branch
from
July 19, 2024 12:17
65d59eb
to
933194d
Compare
Quality Gate passedIssues Measures |
infiloop2
approved these changes
Jul 19, 2024
FelixFan1992
approved these changes
Jul 19, 2024
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/AUTO-9355
This PR removes the old log buffer and the corresponding feature flag from the code; we want to use the new buffer by default moving forward
Test results
50x2 upkeeps
50x10 upkeeps
50x10+1 upkeeps
Node upgrade tests passing: https://github.com/smartcontractkit/chainlink/actions/runs/10010662768/job/27672458705