[BCF-3143] multiple address bindings #13992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EasterTheBunny
force-pushed
the
BCF-3143-multiple-address-bindings
branch
from
ebbf57e
to
943aaf8
Compare
ilija42
reviewed
Aug 2, 2024
EasterTheBunny
force-pushed
the
BCF-3143-multiple-address-bindings
branch
from
943aaf8
to
49eb6d1
Compare
EasterTheBunny
force-pushed
the
BCF-3143-multiple-address-bindings
branch
from
caa52ea
to
580b02d
Compare
EasterTheBunny
force-pushed
the
BCF-3143-multiple-address-bindings
branch
from
4a04c2b
to
dd7c621
Compare
EasterTheBunny
force-pushed
the
BCF-3143-multiple-address-bindings
branch
from
46abca3
to
8dcf3b4
Compare
EasterTheBunny
force-pushed
the
BCF-3143-multiple-address-bindings
branch
4 times, most recently
from
2e63368
to
21de883
Compare
ilija42
reviewed
Aug 6, 2024
ilija42
reviewed
Aug 6, 2024
ilija42
reviewed
Aug 6, 2024
ilija42
reviewed
Aug 6, 2024
ilija42
reviewed
Aug 6, 2024
ilija42
reviewed
Aug 6, 2024
EasterTheBunny
force-pushed
the
BCF-3143-multiple-address-bindings
branch
from
45ebc2b
to
51ce53e
Compare
ilija42
reviewed
Sep 9, 2024
ilija42
reviewed
Sep 9, 2024
ilija42
reviewed
Sep 9, 2024
ilija42
reviewed
Sep 9, 2024
| } | ||
|
|
||
| // filterRegisterer isn't required here because the event can also be polled for by the contractBinding common filter. | ||
| if b.registrar != nil { |
There was a problem hiding this comment.
just add a return if registrar is nil to omit these checks
There was a problem hiding this comment.
Do you mean return early if no registrar exists?
EasterTheBunny
changed the title
ilija42
reviewed
Sep 9, 2024
ilija42
reviewed
Sep 9, 2024
ilija42
previously approved these changes
Sep 9, 2024
jmank88
reviewed
Sep 9, 2024
EasterTheBunny
changed the title
Co-authored-by: Jordan Krage <[email protected]>
ilija42
previously approved these changes
Sep 9, 2024
jmank88
approved these changes
Sep 9, 2024
|
ilija42
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
BCF-3143
Supporting PRs
Description
Applies changes in
ContractReaderto support multiple address bindings.Requires Dependencies
Resolves Dependencies