feat(docker): add observability stack #14203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Atrax1
commented
Aug 22, 2024
Atrax1
commented
- Add prometheus, grafana, alertmanager to docker compose
- Can enable using env var
Atrax1
force-pushed
the
BCF-3345-add-grafana-prometheus-to-docker-compose-stack
branch
from
4e79844
to
dd65e2d
Compare
|
| group_by: [ alertname ] | ||
|
|
||
|
|
||
| receivers: |
There was a problem hiding this comment.
how will these alerts work? where are they defined?
There was a problem hiding this comment.
This is only useful in case you have prometheus alerts created by you. I actually don't use alertmanager and observability-lib is creating grafana managed alert rules. Could be removed or optional depending on a flag
patrickhuie19
approved these changes
Aug 27, 2024
jmank88
approved these changes
Aug 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Atrax1
deleted the
BCF-3345-add-grafana-prometheus-to-docker-compose-stack
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.