Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1505] fix name of step used to generate changesets #14217

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Aug 23, 2024

PR scope:

  • fix changeset generation and update step name
  • modify artifact name to include base_ref
  • copy foundry.toml to root folder before running Slither so that all dependencies can be found (like in regular Solidity Foundry pipeline)

Tests:

  • generate artifact for automation for current SHA and v2.13.0 and check if changesets are there
  • generate for shared for current SHA and v2.13.0 and check if both files from root folder and shared folder are included
  • check if contracts that failed to be compiled due to missing dependencies can be compiled now by Slither
  • make sure artifact name contains base ref

@Tofel Tofel changed the title fix name of step used to generate changesets [TT-1505] fix name of step used to generate changesets Aug 26, 2024
@Tofel Tofel marked this pull request as ready for review August 26, 2024 07:51
@Tofel Tofel requested review from a team as code owners August 26, 2024 07:51
lukaszcl
lukaszcl previously approved these changes Aug 26, 2024
@Tofel Tofel added this pull request to the merge queue Aug 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 26, 2024
@Tofel Tofel added this pull request to the merge queue Aug 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 26, 2024
@Tofel Tofel added this pull request to the merge queue Aug 26, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Merged via the queue into develop with commit 3d2efc3 Aug 26, 2024
75 checks passed
@Tofel Tofel deleted the fix_changeset_generation branch August 26, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants