[OPCORE-855]: fix: support creating more than 1 manager #14225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support connection to multiple feed managers due to an upcoming CCIP v2 requirement, we want to update the logic to allow more than 1 feed managers to be created per node. The new behaviour is hidden under a feature tag. JIRA: https://smartcontract-it.atlassian.net/browse/OPCORE-855
graham-chainlink
requested review from
samsondav
and removed request for
a team
To guarantee the order that is return is the same now that we support multiple feeds managers, we want to order by created_at
|
jmank88
reviewed
Aug 26, 2024
| type SingleFeedsManagerError implements Error { | ||
| message: String! | ||
| code: ErrorCode! | ||
| } | ||
|
|
||
| # CreateFeedsManagerPayload defines the response when creating a feeds manager | ||
| union CreateFeedsManagerPayload = CreateFeedsManagerSuccess | ||
| | SingleFeedsManagerError | ||
| | DuplicateFeedsManagerError | ||
| | SingleFeedsManagerError # // TODO: delete once multiple feeds managers support is released |
There was a problem hiding this comment.
Is there a ticket to link for these?
There was a problem hiding this comment.
Do you mean a ticket to cleanup the SingleFeedsManagerError ?
I have created one just now https://smartcontract-it.atlassian.net/browse/OPCORE-890
MStreet3
approved these changes
Aug 28, 2024
eutopian
approved these changes
Aug 29, 2024
eutopian
merged commit 87b77cf
into
ggoh/OPCORE-863/multiple-feeds-manager-start
125 of 131 checks passed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
* fix(service): start multiple feeds managers In order to support connection to multiple feed managers, when on start of the node, we want to attempt to connect to list of registered feed managers. * fix: feature flag for multi feeds managers Introduce a new feature flag for enabling support for multi feeds managers. * refactor(service): delete ListJobProposals No longer used, since it was replaced by ListJobProposalsByManagersIDs * [OPCORE-855]: fix: support creating more than 1 manager (#14225) --------- Co-authored-by: Margaret Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support connection to multiple feed managers due to an upcoming CCIP v2 requirement, we want to update the logic to allow more than 1 feed managers to be created per node.
The new behaviour is hidden under a feature tag.
JIRA: https://smartcontract-it.atlassian.net/browse/OPCORE-855
Requires Dependencies
Depends on this PR which introduces the new feature tag.
Resolves Dependencies