support new heads polling over http rpc client #14373
Open
+182
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-of-head-subscriptions
…-flag-for-NewHeadsPollInterval add new flag, NewHeadsPollInterval
…op handling logic. To add unit test
huangzhen1997
requested review from
reductionista,
DylanTinianov and
dhaidashenko
huangzhen1997
changed the title
dhaidashenko
requested changes
Sep 19, 2024
dhaidashenko
previously approved these changes
Sep 20, 2024
|
| if r.newHeadsPollInterval > 0 { | ||
| interval := r.newHeadsPollInterval | ||
| timeout := interval | ||
| poller, _ := commonclient.NewPoller[*evmtypes.Head](interval, r.latestBlock, timeout, r.rpcLog) |
There was a problem hiding this comment.
Why copy r.newHeadsPollInterval twice? Not a big deal either way I guess, just wondering why not just:
poller, _ := commonclient.NewPoller[*evmtypes.Head](interval, r.latestBlock, interval, r.rpcLog)
or even:
poller, _ := commonclient.NewPoller[*evmtypes.Head](r.newHeadsPollInterval, r.latestBlock, r.newHeadsPollInterval, r.rpcLog)
?
There was a problem hiding this comment.
It makes the line 499 more readable, so it's not looking like passing the same parameter twice. And it's more configurable if we decided to update the timeout value later. And it's consistent with the SubscribeToFinalizedHeads function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EVM RPCClient uses web sockets to provide users with nearly real-time access to new blocks. While WS provides better performance, its reliability is sometimes not sufficient. We should be able to use HTTP instead.
In this PR:
NewHeadsPollInterval(>0 indicate the polling new head is enabled), it's done with a separate PR for better readability hopefully.In another PR we make the ws url optional if Logbroadcaster is disabled.
Tickets:
BCFR-706