MERC-6299 Skip telemetry for market status bridges #14415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-cll
requested review from
george-dorin
and removed request for
a team
martin-cll
force-pushed
the
ml/v4-telemetry
branch
2 times, most recently
from
968e832
to
5039d6f
Compare
martin-cll
changed the title
samsondav
previously approved these changes
Sep 16, 2024
martin-cll
force-pushed
the
ml/v4-telemetry
branch
from
1de20c5
to
2d3b859
Compare
martin-cll
force-pushed
the
ml/v4-telemetry
branch
from
2d3b859
to
991d5db
Compare
samsondav
approved these changes
Sep 19, 2024
akuzni2
approved these changes
Sep 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
How the telemetry code works right now is that inside
collectMercuryEnhancedTelemetry, we loop over each bridge task and for each one, we parse out some fields and send 1 piece of telemetry. Now that we have a new market status type of bridge, we want to skip sending telemetry for it in order to not break downstream analytics that assume pricing bridges only. The market status value is still being sent in theobserved_market_statusfield so we are not losing any information.Changes
Parse the bridge task's request parameters and use either the
endpointvalue or the presence of amarketfield (in case theendpointwas omitted) to infer that the bridge a market status bridge.Also skip over attempting to parse the bid and ask prices for v4 schemas which have no bid or ask prices.