[TT-1624] Make sure that each Solidity change has a corresponding Solidity Review issue in Jira

[Tofel]

Context: https://smartcontract-it.atlassian.net/browse/TT-1624

Tests executed on local:

• no PR issue in changeset -> FAILURE
• Solidity Review in changeset -> do not create new one -> do not update changset -> expect: PASS
• No Solidity Review in changset -> no Open exists -> create new one -> update changeset -> expect: PASS
• No Solidity Review in changset -> Open exists -> use existing -> update changeset -> expect: PASS
• No Solidity Review in changset -> no Open exists -> cannot find template -> expect: FAILURE
• No Solidity Review in changset -> no Open exists -> cannot create new issue -> expect: FAILURE
• No Solidity Review in changset -> no Open exists -> cannot copy child issues -> close parent issue -> expect: FAILURE
• No Solidity Review in changset -> no Open exists -> cannot copy 2nd template -> close 1st cloned issue -> close parent issue -> expect: FAILURE
• No Solidity Review in changset -> no Open exists -> create new one -> cannot link epics to parent -> expect: FAILURE
• No Solidity Review in changset -> no Open exists -> create new one -> cannot link to PR issue -> expect: FAILURE
• No Solidity Review in changset -> more than one Open exists -> expect: FAILURE
• Solidity Review in changset -> doesn't exist in JIRA -> expect: FAILURE

Tests executed in CI:

• no PR issue in changeset -> FAILURE
• Solidity Review in changeset -> do not create new one -> do not update changset -> expect: PASS
• No Solidity Review in changset -> no Open exists -> create new one -> update changeset -> expect: PASS
• No Solidity Review in changset -> Open exists -> use existing -> update changeset -> expect: PASS

Regression tests executed in CI:

• jira issue can be extracted from PR title, etc
• fix version is set correctly for core changes
• artifact pipeline correctly processes changesets

Example of a run, where we added existing Solidity Review issue to the changeset: https://github.com/smartcontractkit/chainlink/actions/runs/10851165446/job/30114271721
Example of a run, where we add a newly created Solidity Review issue to the changeset: https://github.com/smartcontractkit/chainlink/actions/runs/10851584999/job/30115688207
Example of a run, where Solidity Review was already in the changeset: https://github.com/smartcontractkit/chainlink/actions/runs/10851705586/job/30116067584

Missing:

• add tests for new functions

[github-actions]

Static analysis results are available

Hey @Tofel, you can view Slither reports in the job summary here or download them as artifact here.

Please check them before merging and make sure you have addressed all issues.

[github-actions]

Solidity Review Jira issue

Hey @Tofel, we have linked this PR to a Jira issue for Solidity Review!

This is a new feature, that's currently in pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
And please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/wet-monkey-signs.md

This PR has been linked to Solidity Review Jira issue: TT-1707

[scheibinger]

Posted a few inline comments and questions.

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube