Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devsvcs-514: update automaiton data streams lookup test contracts #14505

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

devsvcs-514: update automaiton data streams lookup test contracts #14505

wants to merge 3 commits into from
+162 −34

Conversation

FelixFan1992
Copy link
Contributor

Requires

Resolves

@FelixFan1992 FelixFan1992 marked this pull request as ready for review September 19, 2024 22:04
@FelixFan1992 FelixFan1992 requested review from Atrax1 and a team and removed request for a team, matYang, RensR, Atrax1, elatoskinas and RayXpub September 19, 2024 22:04
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to contracts. Please run pnpm changeset in the contracts directory to add a changeset.

shileiwill
shileiwill previously approved these changes Sep 19, 2024
View reviewed changes
KuphJr
KuphJr previously approved these changes Sep 19, 2024
View reviewed changes
anirudhwarrier
anirudhwarrier requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@anirudhwarrier anirudhwarrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data streams related smoke tests are failing now

@FelixFan1992 FelixFan1992 dismissed stale reviews from KuphJr and shileiwill via f6449f4 September 20, 2024 14:27
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@FelixFan1992 FelixFan1992 marked this pull request as draft September 20, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anirudhwarrier anirudhwarrier anirudhwarrier requested changes

@shileiwill shileiwill shileiwill left review comments

@KuphJr KuphJr KuphJr left review comments

@RensR RensR Awaiting requested review from RensR RensR will be requested when the pull request is marked ready for review RensR is a code owner

@matYang matYang Awaiting requested review from matYang matYang will be requested when the pull request is marked ready for review matYang is a code owner

@RayXpub RayXpub Awaiting requested review from RayXpub RayXpub will be requested when the pull request is marked ready for review RayXpub is a code owner

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas will be requested when the pull request is marked ready for review elatoskinas is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FelixFan1992 @shileiwill @anirudhwarrier @KuphJr