Advanced Querying for ChainReader #14511
Conversation
silaslenihan
force-pushed
the
BCFR-44-Advanced-CR-Querying
branch
6 times, most recently
from
29104d4
to
da45a6b
Compare
silaslenihan
force-pushed
the
BCFR-44-Advanced-CR-Querying
branch
8 times, most recently
from
fb630e1
to
3f75c64
Compare
silaslenihan
force-pushed
the
BCFR-44-Advanced-CR-Querying
branch
2 times, most recently
from
4af0076
to
1e6d7cb
Compare
Solidity Review Jira issueHey! We have taken the liberty to link this PR to a Jira issue for Solidity Review. This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one. Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: This PR has been linked to Solidity Review Jira issue: BCFR-957 |
silaslenihan
changed the title
silaslenihan
requested review from
a team,
RensR,
matYang,
RayXpub and
elatoskinas
as code owners
silaslenihan
force-pushed
the
BCFR-44-Advanced-CR-Querying
branch
from
90a51b4
to
8b8c047
Compare
| if r := recover(); r != nil { | ||
| err = fmt.Errorf("%w: cannot encode %s data word comparator", commontypes.ErrInvalidType, dwTypeID) |
There was a problem hiding this comment.
Why are we expecting a panic?
There was a problem hiding this comment.
I added this, geth abi package in some scenarios panics instead of throwing an error
There was a problem hiding this comment.
How about mentioning "recovered from panic" somewhere in the returned error? And r is critical to include as well.
There was a problem hiding this comment.
Updated the error message accordingly.
silaslenihan
force-pushed
the
BCFR-44-Advanced-CR-Querying
branch
from
8b8c047
to
6d8ed55
Compare
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
* Advanced Querying for ChainReader * Handle pointer type value comparator encoding * Handle geth abi panic when encoding data word value comparators * fix linting issues * [Bot] Update changeset file with jira issues * fix linting issues * [Bot] Update changeset file with jira issues * fix linting issues * [Bot] Update changeset file with jira issues * changed function name and added comments --------- Co-authored-by: ilija <[email protected]> Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
Corresponding ticket: BCFR-44
Requires
smartcontractkit/chainlink-common#798
smartcontractkit/chainlink-solana#869
Resolves