CCIP-3416 paginate token admin registry get all tokens call #14514
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogtownsend
changed the title
ogtownsend
force-pushed
the
CCIP-3416-token-admin-registry-get-all-configured-tokens-handling
branch
from
61666a8
to
70bc529
Compare
ogtownsend
force-pushed
the
CCIP-3416-token-admin-registry-get-all-configured-tokens-handling
branch
from
70bc529
to
852c40e
Compare
AnieeG
approved these changes
Sep 20, 2024
| type TokenAdminRegistryView struct { | ||
| types.ContractMetaData | ||
| Tokens []common.Address `json:"tokens"` | ||
| } | ||
|
|
||
| func GenerateTokenAdminRegistryView(taContract *token_admin_registry.TokenAdminRegistry) (TokenAdminRegistryView, error) { | ||
| tokens, err := taContract.GetAllConfiguredTokens(nil, 0, 10) | ||
| if taContract == nil { |
There was a problem hiding this comment.
nice! should have this in every view
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCIP-3416
Paginate call to
GetAllConfiguredTokenssince this can theoretically grow pretty large