deployment/ccip/changeset: add messaging test #15166
Merged
+388
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small refactor to the request helpers to allow for specifying all fields of the message.
|
I see you updated files related to
|
AER Report: Operator UI CI ran successfully ✅AER Report: CI Core ran successfully ✅ |
makramkd
requested review from
reductionista,
winder,
rstout,
asoliman92,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
0xnogo
reviewed
Nov 11, 2024
0xnogo
reviewed
Nov 11, 2024
| @@ -83,7 +84,13 @@ func TestInitialDeployOnLocal(t *testing.T) { | |||
| require.NoError(t, err) | |||
| block := latesthdr.Number.Uint64() | |||
| startBlocks[dest] = &block | |||
| seqNum := ccdeploy.TestSendRequest(t, e, state, src, dest, false, nil) | |||
| seqNum := ccdeploy.TestSendRequest(t, e, state, src, dest, false, router.ClientEVM2AnyMessage{ | |||
There was a problem hiding this comment.
nit/ what about a TestSend(Dummy|Default)Request? I could convenient to have it so that we won't deal with creating those fields if we are not going to use them.
There was a problem hiding this comment.
Yeah, I thought about adding that but I think we wanna see how the usage of these funcs evolves and build abstractions after we have many use cases. I think for now this is the most flexible, and can improve further.
george-dorin
previously approved these changes
Nov 11, 2024
jmank88
previously approved these changes
Nov 11, 2024
makramkd
dismissed stale reviews from jmank88, george-dorin, and 0xnogo
via
ffd593f
0xnogo
approved these changes
Nov 11, 2024
jmank88
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: Small refactor to the request helpers to allow for specifying all fields of the message.
Requires smartcontractkit/chainlink-ccip#311