Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chainreader get latest value with head data #15188

Merged
merged 9 commits into from
Nov 13, 2024
Merged

chainreader get latest value with head data #15188

merged 9 commits into from
Nov 13, 2024
+147 −72

Conversation

ettec
Copy link
Collaborator

@ettec ettec commented Nov 11, 2024

Addition of method to get latest value with head data required for-> https://smartcontract-it.atlassian.net/browse/CAPPL-108

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

ettec
ettec commented Nov 11, 2024
View reviewed changes
tools/bin/go_core_tests Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

ilija42
ilija42 requested changes Nov 12, 2024
View reviewed changes
core/services/relay/evm/chain_reader.go Outdated Show resolved Hide resolved
@ettec ettec marked this pull request as ready for review November 13, 2024 09:54
@ettec ettec requested review from a team as code owners November 13, 2024 09:54
ilija42
ilija42 previously approved these changes Nov 13, 2024
View reviewed changes
@ettec ettec added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@ettec ettec added this pull request to the merge queue Nov 13, 2024
Merged via the queue into develop with commit 973adb5 Nov 13, 2024
139 of 141 checks passed
@ettec ettec deleted the rc-chainreader branch November 13, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija42 ilija42 ilija42 approved these changes

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@agparadiso agparadiso agparadiso approved these changes

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19 patrickhuie19 is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ettec @vyzaldysanchez @agparadiso @cedric-cordenier @ilija42