-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error handling in TP/ICAP #3627
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 75d4e42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
@@ -50,11 +50,23 @@ export const generateTransport = (generatePriceOptions: GeneratePriceOptions) => | |||
|
|||
return new Promise((resolve) => { | |||
connection.addEventListener('message', (event: MessageEvent) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This EA has been merged into TP, we don't want to make changes here
Can we update the README instead saying "this is deprecated and use TP instead"?
if ( | ||
info === | ||
'Server requested disconnection (code 2): Client limits for JSONWS exceeded (2 clients, 1 allowed)' | ||
) { | ||
logger.error(`${info}`) | ||
} else if (info === 'Authentication failed (check credentials)') { | ||
logger.error(`${info}`) | ||
} | ||
logger.error(`${info}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need these if else statement? They all seem to just log the error
Closes #DF20204
Description
Error Handling in TP/ICAP
Quality Assurance
infra-k8s
configuration file.adapter-secrets
configuration file or update the soak testing blacklist.test-payload.json
file with relevant requests.feature/x
,chore/x
,release/x
,hotfix/x
,fix/x
) or is created from Jira.