responseListener.listenForResponseFromTransaction #190
Conversation
tasks/Functions-consumer/request.js
Outdated
| spinner.start( | ||
| `Request ${requestId} has been initiated. Waiting for fulfillment from the Decentralized Oracle Network...\n` | ||
| `Request ${requestTxReceipt.events[2].args.id} has been initiated. Waiting for fulfillment from the Decentralized Oracle Network...\n` |
There was a problem hiding this comment.
I changed other examples to print a transaction hash here and the request ID only after fulfillment. Maybe do the same here?
There was a problem hiding this comment.
Is there informational value in having both? something along the lines of:
RequestId ${reqId} is waiting for fulfillment from the Decentralized Oracle Network. Track this fulfillment by its Tx hash ${txHash}.
networks.js
Outdated
| @@ -101,7 +101,7 @@ const networks = { | |||
| accounts, | |||
| verifyApiKey: process.env.POLYGONSCAN_API_KEY || "UNSET", | |||
| chainId: 80001, | |||
| confirmations: DEFAULT_VERIFICATION_BLOCK_CONFIRMATIONS, | |||
| confirmations: DEFAULT_VERIFICATION_BLOCK_CONFIRMATIONS * 4, | |||
There was a problem hiding this comment.
That looks a little weird. Does it actually hurt to keep it at DEFAULT?
There was a problem hiding this comment.
do we want to have network specific defaults?
There was a problem hiding this comment.
I'll just set this to 10 blocks. I've noticed that it can be a problem if we don't wait long enough before verifying contracts.
There was a problem hiding this comment.
10 blocks on Sepolia is 2 minutes, way too slow IMO
networks.js
Outdated
| @@ -101,7 +101,7 @@ const networks = { | |||
| accounts, | |||
| verifyApiKey: process.env.POLYGONSCAN_API_KEY || "UNSET", | |||
| chainId: 80001, | |||
| confirmations: DEFAULT_VERIFICATION_BLOCK_CONFIRMATIONS, | |||
| confirmations: DEFAULT_VERIFICATION_BLOCK_CONFIRMATIONS * 4, | |||
There was a problem hiding this comment.
do we want to have network specific defaults?
tasks/Functions-consumer/request.js
Outdated
| spinner.start( | ||
| `Request ${requestId} has been initiated. Waiting for fulfillment from the Decentralized Oracle Network...\n` | ||
| `Request ${requestTxReceipt.events[2].args.id} has been initiated. Waiting for fulfillment from the Decentralized Oracle Network...\n` |
There was a problem hiding this comment.
Is there informational value in having both? something along the lines of:
RequestId ${reqId} is waiting for fulfillment from the Decentralized Oracle Network. Track this fulfillment by its Tx hash ${txHash}.
Use new
responseListener.listenForResponseFromTransactionmethod from the latest Functions Toolkit release