Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace require with assert #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nanexcool
Copy link

Require has very descriptive error messages, plus returns extra gas... too nice and not shitty enough :)

Require has very descriptive error messages, plus returns extra gas... too nice and not shitty enough :)
@JesseAbram
Copy link
Contributor

ok I love it but what if you kept require (I know not as bad on gas) but you used the error messages to make fun of the user? Or just be totally unhelpful

@nanexcool
Copy link
Author

nanexcool commented Aug 29, 2021 via email

@JesseAbram
Copy link
Contributor

I was literally thinking the same thing!

@smartcontracts
Copy link
Owner

I propose we override require to do a loop to burn the gas

@grGred
Copy link

grGred commented Jul 18, 2022

I'm not sure, but it can be done with if revert. Or does it return extra gas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants