handle noContentType correctly for fetch adapter

smartlyio · Dec 11, 2023 · e6d5583 · e6d5583
1 parent f5d0e5d
commit e6d5583
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/packages/oats-fetch-adapter/index.ts b/packages/oats-fetch-adapter/index.ts
@@ -29,7 +29,7 @@ function toRequestData(data: runtime.server.RequestBody<any> | undefined) {
 
 function getContentType(response: Response) {
   const type = response.headers.get('content-type');
-  if (!type) {
+  if (!type || type === runtime.noContentContentType) {
     return runtime.noContentContentType;
   }
   if (response.status === 204) {

diff --git a/test/fetch-adapter/fetch-adapter.spec.ts b/test/fetch-adapter/fetch-adapter.spec.ts
@@ -187,4 +187,27 @@ describe('fetch adapter', () => {
       value: { one: 'the loneliest number' }
     });
   });
+
+  it('correctly calls PATCH(or any) request with noContentType', async () => {
+    const response = await apiClient['with-patch'].patch({
+      status: 204,
+      body: {
+        contentType: runtime.noContentContentType,
+        value: { one: 'the loneliest number' }
+      }
+    });
+
+    expect(response.status).toBe(204);
+    expect(response.value.contentType).toBe(runtime.noContentContentType);
+    expect(response.value.value).toBe('done');
+
+    expect(receivedContext).toBeDefined();
+    expect(receivedContext.method).toEqual('patch');
+    expect(receivedContext.path).toEqual('/with-patch');
+    expect(receivedContext.headers).toEqual(null);
+    expect(receivedContext.body).toEqual({
+      contentType: runtime.noContentContentType,
+      value: { one: 'the loneliest number' }
+    });
+  });
 });