Only show GstSink when playback has started, closes Cimbali#222

smbct · Nov 4, 2021 · 910a331 · 910a331
1 parent ce57d08
commit 910a331
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 14 deletions.
diff --git a/pympress/media_overlays/gst_backend.py b/pympress/media_overlays/gst_backend.py
@@ -55,7 +55,7 @@ def __init__(self, *args, **kwargs):
         self.media_overlay.remove(self.movie_zone)
         self.media_overlay.pack_start(self.sink.props.widget, True, True,  0)
         self.media_overlay.reorder_child(self.sink.props.widget, 0)
-        self.sink.props.widget.show()
+        self.sink.props.widget.hide()
 
         # Create bus to get events from GStreamer playin
         bus = self.playbin.get_bus()
@@ -101,6 +101,7 @@ def on_play(self, *args):
         """
         GLib.idle_add(self.do_update_duration)
         GLib.timeout_add(200, self.do_update_time)
+        self.sink.props.widget.show()
 
 
     def do_update_duration(self, *args):
@@ -150,6 +151,7 @@ def do_stop(self):
         """
         self.playbin.set_state(Gst.State.NULL)
         self.playbin.set_state(Gst.State.READY)
+        self.sink.props.widget.hide()
 
         return False
 

diff --git a/pympress/share/xml/media_overlay.glade b/pympress/share/xml/media_overlay.glade
@@ -7,19 +7,6 @@
     <property name="can-focus">False</property>
     <property name="orientation">vertical</property>
     <signal name="map" handler="handle_embed" swapped="no"/>
-    <child>
-      <object class="GtkDrawingArea" id="movie_zone">
-        <property name="visible">True</property>
-        <property name="can-focus">False</property>
-        <property name="events">GDK_BUTTON_PRESS_MASK | GDK_STRUCTURE_MASK</property>
-        <signal name="button-press-event" handler="play_pause" swapped="no"/>
-      </object>
-      <packing>
-        <property name="expand">True</property>
-        <property name="fill">True</property>
-        <property name="position">0</property>
-      </packing>
-    </child>
     <child>
       <object class="GtkBox" id="toolbar">
         <property name="visible">True</property>
@@ -99,6 +86,21 @@
       <packing>
         <property name="expand">False</property>
         <property name="fill">False</property>
+        <property name="pack-type">end</property>
+        <property name="position">0</property>
+      </packing>
+    </child>
+    <child>
+      <object class="GtkDrawingArea" id="movie_zone">
+        <property name="visible">True</property>
+        <property name="can-focus">False</property>
+        <property name="events">GDK_BUTTON_PRESS_MASK | GDK_STRUCTURE_MASK</property>
+        <signal name="button-press-event" handler="play_pause" swapped="no"/>
+      </object>
+      <packing>
+        <property name="expand">True</property>
+        <property name="fill">True</property>
+        <property name="pack-type">end</property>
         <property name="position">1</property>
       </packing>
     </child>