Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update target.py #1750

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update target.py #1750

wants to merge 1 commit into from

Conversation

MiChaelinzo
Copy link

Changed variable names to follow snake_case naming convention Removed unnecessary comments
Simplified the validation for targetType and targetValue by using the if not statement Merged the getAddresses function and added the validation for IPV6_ADDRESS Merged the getNames function

Changed variable names to follow snake_case naming convention
Removed unnecessary comments
Simplified the validation for targetType and targetValue by using the if not statement
Merged the getAddresses function and added the validation for IPV6_ADDRESS
Merged the getNames function
@bcoles
Copy link
Contributor

bcoles commented Jan 29, 2023

There's a lot happening in this commit and it's not clear what is being changed or why.

The code comments are intentional and should remain.

It appears the matches function has been removed entirely for some reason. This will break things.

Any changes to the classes also require changes to the associated unit and integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants