Skip to content

Commit

Permalink
Update ktlint and fix lint issues (#77)
Browse files Browse the repository at this point in the history
* added smart selfie models

* setting up android JT4 setup

* added jt4 endpoints on android

* updated pigeon shared code

* added android platform code

* updated dart platform interface

* iOS platform interface setup

* Update Mapper.swift

* updated ios platform code

* Update SmileIDPlugin.kt

* pass image path on JT4 jobs

* updated pigeon and ktlint

* revert back ktlint update

* cleanup unused import

* lint android code

* updated CHANGELOG.md

* updated import ordering

* updated ktlint

* updated ktlint

* fixed ktlint warnings

* test ktlint fix

* updated ktlint config

* bump up ktlint version

* update ktlint version

* updated deps and ktlint rules

* fixed indentation lint issue

* fix lint issues

* fix lint issues

* fixed code docs
  • Loading branch information
jumaallan authored Jun 13, 2024
1 parent 7c95707 commit bb0c2c6
Show file tree
Hide file tree
Showing 13 changed files with 559 additions and 473 deletions.
1 change: 1 addition & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@ max_line_length=100

[{*.kt,*.kts}]
ij_kotlin_imports_layout = *,java.**,javax.**,kotlin.**,^
ktlint_function_naming_ignore_when_annotated_with = Composable
ij_kotlin_allow_trailing_comma_on_call_site=true
ij_kotlin_allow_trailing_comma=true
3 changes: 2 additions & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ jobs:
- name: Lint Android
uses: musichin/ktlint-check@v3
with:
ktlint-version: "0.49.1"
ktlint-version: "1.1.1"
code-style: android_studio
patterns: |
**/**.kt
!**/generated/**
Expand Down
8 changes: 4 additions & 4 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ buildscript {
}

dependencies {
classpath "com.android.tools.build:gradle:8.1.2"
classpath "com.android.tools.build:gradle:8.1.4"
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
classpath "org.jlleitschuh.gradle:ktlint-gradle:11.6.1"
classpath "org.jlleitschuh.gradle:ktlint-gradle:12.1.1"
}
}

Expand Down Expand Up @@ -68,7 +68,7 @@ android {
implementation "org.jetbrains.kotlinx:kotlinx-collections-immutable:0.3.6"

testImplementation "org.jetbrains.kotlin:kotlin-test"
testImplementation "io.mockk:mockk:1.13.8"
testImplementation "io.mockk:mockk:1.13.11"
}
}

Expand All @@ -77,4 +77,4 @@ ktlint {
filter {
exclude { it.file.path.contains(".g.kt") }
}
}
}
Loading

0 comments on commit bb0c2c6

Please sign in to comment.