feat(smithydotnet): add dependency error from localservice trait #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texastony
previously approved these changes
Sep 1, 2023
lucasmcdonald3
previously approved these changes
Sep 20, 2023
Co-authored-by: Lucas McDonald <[email protected]>
Co-authored-by: Lucas McDonald <[email protected]>
lucasmcdonald3
approved these changes
Sep 20, 2023
ShubhamChaturvedi7
pushed a commit
to ShubhamChaturvedi7/smithy-dafny
that referenced
this pull request
Apr 24, 2024
…thy-lang#288) --------- Co-authored-by: Lucas McDonald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
localService in smithy can have dependencies in order to properly model all errors the service or dependent services can throw.
Here we go through the localServiceTrait and check if we have dependencies and add the appropriate namespace to the set so the errors can be correctly written. This prevents valid errors from dependencies convert to Default Opaque objects loosing the stack error message
SIM to track work of adding back unused modeled dependency: https://sim.amazon.com/issues/CrypTool-5231
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.