feat: Support IsLimitSet and similar members #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texastony
requested changes
Nov 16, 2023
...afny-codegen/src/main/java/software/amazon/polymorph/smithydotnet/TypeConversionCodegen.java
Outdated
Show resolved
Hide resolved
...afny-codegen/src/main/java/software/amazon/polymorph/smithydotnet/TypeConversionCodegen.java
Outdated
Show resolved
Hide resolved
...afny-codegen/src/main/java/software/amazon/polymorph/smithydotnet/TypeConversionCodegen.java
Outdated
Show resolved
Hide resolved
...afny-codegen/src/main/java/software/amazon/polymorph/smithydotnet/TypeConversionCodegen.java
Outdated
Show resolved
Hide resolved
...afny-codegen/src/main/java/software/amazon/polymorph/smithydotnet/TypeConversionCodegen.java
Outdated
Show resolved
Hide resolved
texastony
reviewed
Nov 16, 2023
| @@ -479,6 +479,24 @@ private String generateConstructorArg(final MemberShape memberShape) { | |||
| nameResolver.classPropertyForStructureMember(memberShape)); | |||
| } | |||
|
|
|||
| // return false if this struct/member is one of the special ones with a IsXxxSet member | |||
There was a problem hiding this comment.
Suggested change
| // return false if this struct/member is one of the special ones with a IsXxxSet member | |
| // return true if this struct/member is one of the special ones with a IsXxxSet member |
texastony
previously approved these changes
Nov 16, 2023
|
Approved with an additional suggestion |
texastony
approved these changes
Nov 16, 2023
ShubhamChaturvedi7
pushed a commit
to ShubhamChaturvedi7/smithy-dafny
that referenced
this pull request
Apr 24, 2024
* feat: Support IsLimitSet and similar members
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.