chore(docs/tests): SQSExtended test model (example of polymorph library calling an AWS service) #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g/smithy-dafny into robin-aws/smithy-init-example
…-lang/smithy-dafny into robin-aws/sqs-extended-test-model
…obin-aws/sqs-extended-test-model # Conflicts: # TestModels/aws-sdks/ddb-lite/model/ComAmazonawsDynamodbTypes.dfy # TestModels/aws-sdks/kms-lite/model/ComAmazonawsKmsTypes.dfy # codegen/smithy-dafny-codegen-test/src/test/java/software/amazon/polymorph/smithydotnet/DotnetTestModels.java # codegen/smithy-dafny-codegen-test/src/test/java/software/amazon/polymorph/smithyjava/JavaTestModels.java
robin-aws
changed the title
…obin-aws/sqs-extended-test-model # Conflicts: # TestModels/aws-sdks/ddb-lite/model/ComAmazonawsDynamodbTypes.dfy # TestModels/aws-sdks/kms-lite/model/ComAmazonawsKmsTypes.dfy
seebees
approved these changes
Oct 31, 2024
| for i := 0 to |messages| { | ||
| var message := messages[i]; | ||
| // TODO: Propogate error instead of terminating | ||
| var receiptHandle :- expect message.ReceiptHandle; |
There was a problem hiding this comment.
I think you should just be able to MapFailure here. The smithy-dafny error type should have a joining error that should just work.
non-blocking point :)
There was a problem hiding this comment.
Yup agreed. I'll address that when I follow up with adding more target languages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a test model intended as an example of how to build a thick client using polymorphing, in this case adding a very common client-side operation for AWS SQS. My intention was to make this a
smithy inittemplate, but as it was significant work to get this example working I'm locking it down in CI first, then will find a way to make a template from it while still testing it.Made several fixes and improvements to get this working in Java and make progress in other languages:
aws.polymorph#localService$configRequiredparameter, defaulting to false. Previously all local services had to provide a default factory method for config structures, but this isn't always reasonable. ForSQSExtendedyou really have to provide an underlying SQS client, and there's no sensible default value for an allocated service client....types.__default.javafile if the{:extern}module has any subset types declared. To move closer to being able to eventually GENERATE ALL THE THINGS, added a dummy subset type in thepolymorph_dafnyoutput so this is always required, and included this empty file when doing--generate client-constructors. This isn't really breaking since all substantial polymorph libraries have lots of constraints in their models and hence subset types declared.BinarySetAttributeValuehandling to useSdkBytescorrectly to all lists of blobs.dafnyErrorcase forToNativeon an arbitrary top-level service error (currently being patched in manually in the MPL).Also added a Setup section to the main README, since there are extra steps now.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.