fix(node-http-handler): fix invalid usage of parsed url (#1408)

* fix(node-http-handler): fix invalid usage of parsed url

* add unit test, changeset

---------

Co-authored-by: George Fu <[email protected]>

.changeset/gold-bugs-sneeze.md

@@ -0,0 +1,5 @@
+---
+"@smithy/node-http-handler": patch
+---
+
+remove brackets from hostname

packages/node-http-handler/src/node-http-handler.spec.ts

@@ -153,6 +153,24 @@ describe("NodeHttpHandler", () => {
         expect(hRequestSpy.mock.calls[0][0]?.port).toEqual(1234);
         expect(hRequestSpy.mock.calls[0][0]?.path).toEqual("/some/path?some=query#fragment");
       });
+
+      it("removes brackets from hostname", async () => {
+        const nodeHttpHandler = new NodeHttpHandler({});
+        const httpRequest = {
+          protocol: "http:",
+          username: "username",
+          password: "password",
+          hostname: "[host]",
+          port: 1234,
+          path: "/some/path",
+          query: {
+            some: "query",
+          },
+          fragment: "fragment",
+        };
+        await nodeHttpHandler.handle(httpRequest as any);
+        expect(hRequestSpy.mock.calls[0][0]?.host).toEqual("host");
+      });
     });
   });
 

packages/node-http-handler/src/node-http-handler.ts

@@ -209,9 +209,17 @@ or increase socketAcquisitionWarningTimeout=(millis) in the NodeHttpHandler conf
       if (request.fragment) {
         path += `#${request.fragment}`;
       }
+
+      let hostname = request.hostname ?? "";
+      if (hostname[0] === "[" && hostname.endsWith("]")) {
+        hostname = request.hostname.slice(1, -1);
+      } else {
+        hostname = request.hostname;
+      }
+
       const nodeHttpsOptions: RequestOptions = {
         headers: request.headers,
-        host: request.hostname,
+        host: hostname,
         method: request.method,
         path,
         port: request.port,