additional test cases for split-header

smithy-lang · Oct 1, 2024 · 3168eda · 3168eda
1 parent 2ab214d
commit 3168eda
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/packages/smithy-client/src/split-header.spec.ts b/packages/smithy-client/src/split-header.spec.ts
@@ -7,9 +7,16 @@ describe(splitHeader.name, () => {
     expect(splitHeader("a, b, c")).toEqual(["a", "b", "c"]);
     expect(splitHeader("a , b , c")).toEqual(["a", "b", "c"]);
     expect(splitHeader(`a , b , "  c  "`)).toEqual(["a", "b", "  c  "]);
+    expect(splitHeader(`  a  ,     , b`)).toEqual(["a", "", "b"]);
+    expect(splitHeader(`,,`)).toEqual(["", "", ""]);
+    expect(splitHeader(`    ,    ,    `)).toEqual(["", "", ""]);
   });
   it("should split a string by commas that are not in quotes, and remove outer quotes", () => {
     expect(splitHeader('"b,c", "\\"def\\"", a')).toEqual(["b,c", '"def"', "a"]);
     expect(splitHeader('"a,b,c", ""def"", "a,b ,c"')).toEqual(["a,b,c", '"def"', "a,b ,c"]);
+    expect(splitHeader(`""`)).toEqual([``]);
+    expect(splitHeader(``)).toEqual([``]);
+    expect(splitHeader(`\\"`)).toEqual([`"`]);
+    expect(splitHeader(`"`)).toEqual([`"`]);
   });
 });
diff --git a/packages/smithy-client/src/split-header.ts b/packages/smithy-client/src/split-header.ts
@@ -34,6 +34,9 @@ export const splitHeader = (value: string): string[] => {
   return values.map((v) => {
     v = v.trim();
     const z = v.length;
+    if (z < 2) {
+      return v;
+    }
     if (v[0] === `"` && v[z - 1] === `"`) {
       v = v.slice(1, z - 1);
     }