Fix default HttpHandlerConfig type for HttpHandler (#918)

smithy-lang · Sep 8, 2023 · 5b3fec3 · 5b3fec3
1 parent ead0614
commit 5b3fec3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/.changeset/afraid-spies-smash.md b/.changeset/afraid-spies-smash.md
@@ -0,0 +1,5 @@
+---
+"@smithy/protocol-http": patch
+---
+
+Fix default HttpHandlerConfig type for HttpHandler
diff --git a/packages/protocol-http/src/extensions/httpExtensionConfiguration.ts b/packages/protocol-http/src/extensions/httpExtensionConfiguration.ts
@@ -3,7 +3,7 @@ import { HttpHandler } from "../httpHandler";
 /**
  * @internal
  */
-export interface HttpHandlerExtensionConfiguration<HandlerConfig extends object = Record<string, unknown>> {
+export interface HttpHandlerExtensionConfiguration<HandlerConfig extends object = {}> {
   setHttpHandler(handler: HttpHandler<HandlerConfig>): void;
   httpHandler(): HttpHandler<HandlerConfig>;
   updateHttpClientConfig(key: keyof HandlerConfig, value: HandlerConfig[typeof key]): void;
@@ -13,7 +13,7 @@ export interface HttpHandlerExtensionConfiguration<HandlerConfig extends object
 /**
  * @internal
  */
-export type HttpHandlerExtensionConfigType<HandlerConfig extends object = Record<string, unknown>> = Partial<{
+export type HttpHandlerExtensionConfigType<HandlerConfig extends object = {}> = Partial<{
   httpHandler: HttpHandler<HandlerConfig>;
 }>;
 
@@ -22,7 +22,7 @@ export type HttpHandlerExtensionConfigType<HandlerConfig extends object = Record
  *
  * Helper function to resolve default extension configuration from runtime config
  */
-export const getHttpHandlerExtensionConfiguration = <HandlerConfig extends object = Record<string, unknown>>(
+export const getHttpHandlerExtensionConfiguration = <HandlerConfig extends object = {}>(
   runtimeConfig: HttpHandlerExtensionConfigType<HandlerConfig>
 ) => {
   let httpHandler = runtimeConfig.httpHandler!;
@@ -47,7 +47,7 @@ export const getHttpHandlerExtensionConfiguration = <HandlerConfig extends objec
  *
  * Helper function to resolve runtime config from default extension configuration
  */
-export const resolveHttpHandlerRuntimeConfig = <HandlerConfig extends object = Record<string, unknown>>(
+export const resolveHttpHandlerRuntimeConfig = <HandlerConfig extends object = {}>(
   httpHandlerExtensionConfiguration: HttpHandlerExtensionConfiguration<HandlerConfig>
 ): HttpHandlerExtensionConfigType<HandlerConfig> => {
   return {

diff --git a/packages/protocol-http/src/httpHandler.ts b/packages/protocol-http/src/httpHandler.ts
@@ -6,7 +6,7 @@ import { HttpResponse } from "./httpResponse";
 /**
  * @internal
  */
-export type HttpHandler<HttpHandlerConfig extends object = Record<string, unknown>> = RequestHandler<
+export type HttpHandler<HttpHandlerConfig extends object = {}> = RequestHandler<
   HttpRequest,
   HttpResponse,
   HttpHandlerOptions