Do not take protocol and port from custom Endpoint (#1374)

smithy-lang · Aug 27, 2024 · 77db9e7 · 77db9e7
1 parent 8b3d752
commit 77db9e7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 14 deletions.
diff --git a/.changeset/good-cheetahs-press.md b/.changeset/good-cheetahs-press.md
@@ -0,0 +1,5 @@
+---
+"@smithy/util-endpoints": patch
+---
+
+Do not take protocol and port from custom Endpoint
diff --git a/packages/util-endpoints/src/__mocks__/test-cases/parse-url.json b/packages/util-endpoints/src/__mocks__/test-cases/parse-url.json
@@ -72,7 +72,7 @@
       },
       "expect": {
         "endpoint": {
-          "url": "http://http-99_ab.com-nopath.example.com"
+          "url": "https://http-99_ab.com-nopath.example.com"
         }
       }
     },
@@ -83,7 +83,7 @@
       },
       "expect": {
         "endpoint": {
-          "url": "http://http-99_ab-.com-nopath.example.com"
+          "url": "https://http-99_ab-.com-nopath.example.com"
         }
       }
     },

diff --git a/packages/util-endpoints/src/resolveEndpoint.ts b/packages/util-endpoints/src/resolveEndpoint.ts
@@ -36,18 +36,6 @@ export const resolveEndpoint = (ruleSetObject: RuleSetObject, options: EndpointR
 
   const endpoint = evaluateRules(rules, { endpointParams, logger, referenceRecord: {} });
 
-  if (options.endpointParams?.Endpoint) {
-    // take protocol and port from custom Endpoint if present.
-    try {
-      const givenEndpoint = new URL(options.endpointParams.Endpoint as string);
-      const { protocol, port } = givenEndpoint;
-      endpoint.url.protocol = protocol;
-      endpoint.url.port = port;
-    } catch (e) {
-      // ignored
-    }
-  }
-
   options.logger?.debug?.(`${debugId} Resolved endpoint: ${toDebugString(endpoint)}`);
 
   return endpoint;