feat(fetch-http-handler): improve performance, replace FileReader with Blob.arrayBuffer() #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richarddd
force-pushed
the
improve-blob-reader
branch
from
98e4234
to
0608d52
Compare
kuhe
reviewed
Jun 17, 2024
|
https://caniuse.com/mdn-api_blob_arraybuffer checks out, and for Node.js if we have Blob (v18) global then it has |
kuhe
force-pushed
the
improve-blob-reader
branch
2 times, most recently
from
43ee9f5
to
2c5ee19
Compare
kuhe
changed the title
kuhe
requested review from
kuhe and
milesziemer
and removed request for
syall
kuhe
force-pushed
the
improve-blob-reader
branch
from
2c5ee19
to
3800626
Compare
trivikr
approved these changes
Oct 18, 2024
siddsriv
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Improve performance of collecting blob body by using
arrayBuffer()method.If one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.