Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for accountId in configValueProvider #1252

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

siddsriv
Copy link
Contributor

@siddsriv siddsriv commented Apr 30, 2024

Issue #, if available:
Internal JS-4633
Part 3

Description of changes:
adds support for accountId in configValueProvider (sourced from credentials)

Testing

 PASS  src/adaptors/createConfigValueProvider.spec.ts (14.921 s)
  createConfigValueProvider
    ✓ should create a normalized provider for any config value (10 ms)
    ✓ should look up both the canonical Endpoint ruleset param name and any localized override (1 ms)
    ✓ uses a special lookup for CredentialScope (1 ms)
    ✓ uses a special lookup for accountId (1 ms)
    ✓ should normalize endpoint objects into URLs (1 ms)

Test Suites: 1 passed, 1 total
Tests:       5 passed, 5 total
Snapshots:   0 total
Time:        15.411 s

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@siddsriv siddsriv requested review from a team as code owners April 30, 2024 05:08
@siddsriv siddsriv marked this pull request as draft April 30, 2024 05:08
@siddsriv siddsriv marked this pull request as ready for review June 18, 2024 18:28
@siddsriv siddsriv force-pushed the accId-config branch 2 times, most recently from 7b7cdda to c596cd4 Compare June 20, 2024 19:55
Copy link
Contributor

@milesziemer milesziemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we should try to move this logic for determining aws endpoint param values like account id and credential scope into the SDK, but looking at the code it seems out of scope here.

@siddsriv siddsriv merged commit 4a40961 into smithy-lang:main Jul 24, 2024
4 checks passed
@siddsriv siddsriv deleted the accId-config branch July 24, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants