fix(middleware-apply-body-checksum): fix request copying with clone #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
fix-body-checksum-request-clone
branch
from
e225edb
to
b5e1202
Compare
kuhe
reviewed
Jul 10, 2024
| ...headers, | ||
| "content-md5": options.base64Encoder(await digest), | ||
| }, | ||
| const cloned = request.clone(); |
There was a problem hiding this comment.
This isn't a safe assumption.
HttpRequest.isInstance(request) is incorrectly implemented. It only checks that a request is duck-like an HttpRequest interface. The clone method only exists on the HttpRequest class.
It wasn't a good idea naming interfaces and classes the same, even worse that they aren't identical types.
kuhe
requested changes
Jul 10, 2024
kuhe
force-pushed
the
fix-body-checksum-request-clone
branch
from
b5e1202
to
f5f42a4
Compare
kuhe
approved these changes
Jul 15, 2024
|
This is no longer necessary due to #1345 |
|
re-opening because this PR is still good for code clarity |
hpmellema
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Fixed a subtle bug when request copying, otherwise methods like
clone()may not be copied over.If one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.