Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate memberName as contextParams value #1365

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Aug 12, 2024

Issue #, if available:
Fixes failing endpoint tests in aws/aws-sdk-js-v3#6373 (comment)

Description of changes:
Populates memberName as contextParams value, so that it can be consumed correctly when populating endpoints.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr
Copy link
Contributor Author

trivikr commented Aug 12, 2024

Codegen PR was posted at aws/aws-sdk-js-v3#6376 for reference

@trivikr
Copy link
Contributor Author

trivikr commented Aug 12, 2024

The fix was verified in simplified endpoints tests in aws/aws-sdk-js-v3#6373 (comment)

@trivikr trivikr marked this pull request as ready for review August 12, 2024 16:27
@trivikr trivikr requested review from a team as code owners August 12, 2024 16:27
@trivikr trivikr requested a review from sugmanue August 12, 2024 16:27
@trivikr trivikr merged commit fa63800 into main Aug 12, 2024
10 checks passed
@trivikr trivikr deleted the endpoint-params-diff branch August 12, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants