Include ./dist/es in published ssdk package files to fix ESM entrypoint #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ssdk packages have `"module": "./dist/es/index.js",` in package.json, but did not include `./dist/es` in their published files to npm. I noticed this when using vite's bundler, which was looking for the ESM entrypoint via the `module` field, but it was unable to find the file because it was not included in the files published to npm. This PR addes the files inside of `./dist/es` to the list of files published to npm.
kuhe
approved these changes
Aug 20, 2024
kstich
approved these changes
Aug 28, 2024
|
This has been merged but there is a release process for NPM which is pending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/a
Description of changes:
The ssdk packages have
"module": "./dist/es/index.js",in package.json, but did not include./dist/esin their published files to npm. I noticed this when using vite's bundler, which was looking for the ESM entrypoint via themodulefield, but it was unable to find the file because it was not included in the files published to npm. This PR addes the files inside of./dist/esto the list of files published to npm to fix this issue.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.