Process Operation Context Params in Endpoints #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
force-pushed
the
codegen-operation-context-params
branch
from
a0ec269
to
e8e2efb
Compare
kuhe
reviewed
Aug 28, 2024
...script-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CommandGenerator.java
Outdated
Show resolved
Hide resolved
kuhe
approved these changes
Aug 28, 2024
kuhe
reviewed
Aug 28, 2024
.../main/java/software/amazon/smithy/typescript/codegen/endpointsV2/RuleSetParameterFinder.java
Outdated
Show resolved
Hide resolved
trivikr
force-pushed
the
codegen-operation-context-params
branch
from
549a580
to
25dfe68
Compare
kuhe
reviewed
Aug 29, 2024
.../main/java/software/amazon/smithy/typescript/codegen/endpointsV2/RuleSetParameterFinder.java
Show resolved
Hide resolved
kuhe
reviewed
Aug 29, 2024
.../main/java/software/amazon/smithy/typescript/codegen/endpointsV2/RuleSetParameterFinder.java
Show resolved
Hide resolved
kuhe
reviewed
Aug 29, 2024
.../main/java/software/amazon/smithy/typescript/codegen/endpointsV2/RuleSetParameterFinder.java
Show resolved
Hide resolved
kuhe
reviewed
Aug 29, 2024
...pt-codegen/src/test/java/software/amazon/smithy/typescript/codegen/CommandGeneratorTest.java
Outdated
Show resolved
Hide resolved
kuhe
approved these changes
Aug 29, 2024
kstich
approved these changes
Aug 29, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Internal JS-5234
Description of changes:
Processes Operation Context Params in Endpoints
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.