Upgrade language server version #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To go along with the changes in the language server 0.4.0: https://github.com/smithy-lang/smithy-language-server/blob/main/CHANGELOG.md#040-2024-07-30, this commit also: - updates coursier to use java 21 to run the server - adds config options diagnostics.minimumSeverity, onlyReloadOnSave - removes config option for logToFile
hpmellema
approved these changes
Jul 30, 2024
|
Need to fix these failing tests |
Most of the test suites read the old .smithy.lsp.log file that the language server could be configured to write out. Since that was removed, we need a different way to do test assertions. I tried to see if we could look at the trace of messages between server <-> vscode client, but wasn't able to find a way. So I simplified the assertions for these test suites, which should be ok because we probably don't want to rely on logs anyways for testing, and more robust testing is done on the server side (our extension doesn't have that much functionality to test). I also had to add `sources` to each of the smithy-build.json files used for tests, so the language server could properly load those test projects.
By default, couriser will use AdoptOpenJDK 8 to run the server, so we needed to tell it to use jdk 21. Coursier will download the JDK if necessary. It uses an index to figure out where to download it from: https://get-coursier.io/docs/2.0.6/cli-java#jvm-index. The version of coursier we are using in the extension has an old version of the index, so we needed to provide an updated index for coursier to pull from. Also, we needed to tell coursier specifically which jdk to use (not just 21), because by default it tries to use AdoptOpenJDK, when there's no AdoptOpenJDK 21 (it is under the name Adoptium) now. This is a temporary solution, meant to avoid downloading a second version of coursier which had an updated index and could properly find the right jdk to download. In the future, we will ship the language server as a standalone executable, and can remove coursier altogether. I also updated the tests to stop using timeouts, so we don't have to worry about an inconsistent download time in CI.
haydenbaker
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To go along with the changes in the language server 0.4.0: https://github.com/smithy-lang/smithy-language-server/blob/main/CHANGELOG.md#040-2024-07-30, this commit also:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.