Add s3 invalid expires protocol test #2094
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
requested review from
a team and
milesziemer
and removed request for
syall and
a team
milesziemer
requested changes
Sep 18, 2024
| protocol: restXml | ||
| }]) | ||
| @http(uri: "/{Bucket}/{Key+}", method: "GET") | ||
| @s3UnwrappedXmlOutput |
There was a problem hiding this comment.
I don't think the actual S3 model has s3UnwrappedXmlOutput on GetObject
| string Delimiter | ||
|
|
||
| string DisplayName | ||
|
|
||
| string Expires |
There was a problem hiding this comment.
Should this be a timestamp? From what I understand, clients should try deserializing as a timestamp, but not fail Expires is invalid, right?
Comment on lines
+386
to
+388
| S3 clients should not fail the request with invalid expires. | ||
| GA SDKs should verify the value in ExpiresString param and | ||
| new SDKs should verifiy the value in Expires param |
There was a problem hiding this comment.
Reword suggestion, if accurate:
Suggested change
| S3 clients should not fail the request with invalid expires. | |
| GA SDKs should verify the value in ExpiresString param and | |
| new SDKs should verifiy the value in Expires param | |
| S3 clients should not fail deserialization of the `Expires` header its | |
| value is not a valid timestamp. Instead, the `Expires` parameter of | |
| the response should be left empty, and the `ExpiresString` parameter | |
| should be populated with the raw value of the header. |
| code: 200, | ||
| headers: { | ||
| "Expires": "foobar1234" | ||
| }, |
There was a problem hiding this comment.
Just an idea, but we could add an ExpiresString member to GetObjectOutput, and update this test to have the following:
Suggested change
| }, | |
| }, | |
| params: { | |
| ExpiresString: "foobar1234" | |
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Add S3 protocol test to validate the request doesn't fail with invalid expires header
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.