Update NullAndEmptyHeadersServer tests for restJson1 and restXml
#2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test now align with the similar tests for clients. They expect empty headers to be serialized as "" and null headers to not be serialized
|
Can confirm that this also impacts Go SDK |
milesziemer
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
NullAndEmptyHeaderClienttests were recently updated to expect empty headers to be serialized. Similar changes were not made for the server variants of those tests. This leads to an unexpected difference in serialization between servers and clients and prevents clients from receiving semantically meaningful headers from the server.The test now align with the similar tests for clients. They expect empty headers to be serialized as "" and null headers to not be serialized
Testing
Confirmed that the same changes made for client header serialization in Bump smithy version to 1.52 smithy-rs#3887 worked for the server tests as well.
Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.