Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add round-trip convertibility of resource schemas #2445

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Add round-trip convertibility of resource schemas #2445

merged 2 commits into from
Nov 13, 2024

Conversation

haydenbaker
Copy link
Contributor

Background

  • Before these changes, converting a node to resource-schema is lossy
  • These changes include the necessary changes to keep round-trips between node and resource-schema lossless
  • Property was adapted to incorporate its separate "properties" as extensions to the schema**
    • **only when these "properties" (insertionOrder, dependencies) is set to a non-default
  • Unknown properties are added as extensions to the Schema

Testing

  • Unit testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haydenbaker haydenbaker marked this pull request as ready for review November 7, 2024 22:01
@haydenbaker haydenbaker requested a review from a team as a code owner November 7, 2024 22:01
@haydenbaker haydenbaker force-pushed the haydenbaker/cfn-resource-schema-conversions branch 3 times, most recently from 6ec3454 to 47437e3 Compare November 13, 2024 16:11
@haydenbaker haydenbaker force-pushed the haydenbaker/cfn-resource-schema-conversions branch from 47437e3 to e0ad918 Compare November 13, 2024 16:13
@kstich kstich dismissed JordonPhillips’s stale review November 13, 2024 17:36

Fix validated by other reviewer

@haydenbaker haydenbaker merged commit ccf6e6a into main Nov 13, 2024
14 checks passed
yasmewad pushed a commit to yasmewad/smithy that referenced this pull request Nov 13, 2024
@haydenbaker @yasmewad
Add round-trip convertibility of resource schemas (smithy-lang#2445)
fcaf7dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstich kstich kstich approved these changes

@JordonPhillips JordonPhillips Awaiting requested review from JordonPhillips

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haydenbaker @JordonPhillips @kstich