Add config for inline JSON Schema maps #2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
force-pushed
the
flat_jsonschema_map_strategies
branch
from
4b8a368
to
29d7ded
Compare
This commit adds the useInlineMaps setting to allow users to configure JSON Schema conversion to inline converted map shapes instead of creating references.
kstich
force-pushed
the
flat_jsonschema_map_strategies
branch
from
29d7ded
to
e754ef4
Compare
JordonPhillips
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2443
This commit adds the
useInlineMapssetting to allow users to configure JSON Schema conversion to inline convertedmapshapes instead of creating references.This is distinct from the
mapStrategysetting in that it's about the placement of the generated type and not how the type is generated. Combining the two would require two strategies for each type of map converted.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.